Adding missing setup steps to developer-notes to ensure new users can push changes upstream
ClosedPublic
Actions

Authored by jasonbcox on Nov 26 2017, 05:26.

Details

Reviewers

deadalnix
schancel

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

Summary

I ran across some issues following the instructions in developer-notes, so I added some instructions to resolve them.

Test Plan

N/A

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Owners added a reviewer: Restricted Owners Package.Nov 26 2017, 05:26

Herald added a reviewer: Restricted Project. · View Herald Transcript

deadalnix requested changes to this revision.Nov 26 2017, 16:46

deadalnix added inline comments.

doc/developer-notes.md
516 ↗	(On Diff #1834)	I don't think this must be an ecdsa key.
523 ↗	(On Diff #1834)	This is not a valid git command.
524 ↗	(On Diff #1834)	Just give instruction to clone from there.

This revision now requires changes to proceed.Nov 26 2017, 16:46

Changed git origin instructions according to feedback, fixed typo, and removed note regarding ECDSA keys.

doc/developer-notes.md
513 ↗	(On Diff #1843)	It should do so automatically when it needs the certificates. If it doesn't then this is a bug.

jasonbcox marked 3 inline comments as done.Dec 3 2017, 03:05

jasonbcox added inline comments.

doc/developer-notes.md
513 ↗	(On Diff #1843)	Trying to arc diff without credentials gives me the following error, so it doesn't look automatic: Usage Exception: YOU NEED TO AUTHENTICATE TO CONTINUE You are trying to connect to a server (reviews.bitcoinabc.org) that you do not have any credentials stored for. To retrieve and store credentials for this server, run this command: $ arc install-certificate