Page MenuHomePhabricator
Differential D721

Set Amount constructor to explicit
ClosedPublic
Actions

Authored by schancel on Nov 26 2017, 17:13.

Details

Reviewers
deadalnix
freetrader
mbhinder
Group Reviewers
Restricted Project
Commits
rSTAGING5b699cd8cbeb: Set Amount constructor to explicit
rABC5b699cd8cbeb: Set Amount constructor to explicit
Summary

Depends on D790

Test Plan

make check
Run QT gui

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Nov 26 2017, 17:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2017, 17:13
deadalnix accepted this revision.Nov 26 2017, 17:43
This revision is now accepted and ready to land.Nov 26 2017, 17:43
schancel updated this revision to Diff 1874.Nov 28 2017, 07:23

Rebasing on top of a few fixes

schancel added a comment.Nov 28 2017, 07:24

This depends on https://reviews.bitcoinabc.org/D735 due to an oversight on my part.

schancel planned changes to this revision.Dec 6 2017, 01:46

This needs several other patches to QT to go in before it can be landed now.

schancel updated this revision to Diff 2045.Dec 11 2017, 19:11

Rebase

This revision is now accepted and ready to land.Dec 11 2017, 19:11
schancel edited the summary of this revision. (Show Details)Dec 11 2017, 19:12
schancel edited the test plan for this revision. (Show Details)
schancel added a parent revision: D790: Complete explicit Amount construction in Qt code.
schancel updated this revision to Diff 2053.Dec 11 2017, 19:50

Rebase

Harbormaster completed remote builds in B1330: Diff 2053.Dec 11 2017, 19:50
Closed by commit rABC5b699cd8cbeb: Set Amount constructor to explicit (authored by schancel). · Explain WhyDec 12 2017, 14:37
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
9 lines
8 lines

Diff 2095

View Options

src/amount.h

Loading...
View Options

src/amount.cpp

Loading...