Paths

Table of Contentst

Differential D7240

[CMAKE] Don't install secp256k1 by default unless it is standalone
ClosedPublic
Actions

Authored by Fabien on Aug 24 2020, 10:42.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC5fcf596a0c43: [CMAKE] Don't install secp256k1 by default unless it is standalone

Summary

It is no longer installed via ninja install but it is still possible
to install it with ninja install-secp256k1 as needed.

Test Plan

On Bitcoin ABC project, check it is no longer installed:

ninja install

And install it via:

ninja install-secp256k1

On secp256k1 standalone library, check the lib is installed as
expected.:

ninja install

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 24 2020, 10:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2020, 10:42

Fabien requested review of this revision.Aug 24 2020, 10:42

Harbormaster completed remote builds in B12453: Diff 23011.Aug 24 2020, 10:57

Fabien added a child revision: D7243: [CMAKE] Better debug install targets.Aug 24 2020, 15:36

Great!

This revision is now accepted and ready to land.Aug 24 2020, 19:42

Fabien added a child revision: D7247: [GITIAN] Use the new build targets to split debug info and stripped bin.Aug 24 2020, 19:57

Closed by commit rABC5fcf596a0c43: [CMAKE] Don't install secp256k1 by default unless it is standalone (authored by Fabien). · Explain WhyAug 25 2020, 06:28

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5fcf596a0c43: [CMAKE] Don't install secp256k1 by default unless it is standalone.

Revision Contents
Changeset List

Path

Size

cmake/

modules/

InstallationHelper.cmake

9 lines

src/

secp256k1/

CMakeLists.txt

16 lines

Diff 23024

View Options

cmake/modules/InstallationHelper.cmake