Page MenuHomePhabricator

Fix running successive user builds when no artifacts are specified in build-configurations.json
AbandonedPublic

Authored by jasonbcox on Sep 4 2020, 02:21.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

If the first artifact is specified in a build config with the following:

  • Of the form: "some/source/file": ""
  • The source file is a single file (not a directory or a pattern that matches multiple files)

Then the first file will be written to <build-dir>/artifacts as a filename rather than a directory.
This makes successive builds fail since the script expects <build-dir>/artifacts to be a directory,
not a file.

Depends on D7353

Test Plan
./build-configurations.py build-source-control-tools
./build-configurations.py build-source-control-tools

Pre-patch, the above fails. Post-patch, it passes. You can also run the first line pre-patch
and the second post-patch and it should also pass.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
build-artifact
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12610
Build 25325: Build Diffbuild-without-wallet · build-diff · build-clang-tidy · build-clang-10
Build 25324: arc lint + arc unit