Page MenuHomePhabricator
Differential D7353

Add check-source-control-tools build config
ClosedPublic
Actions

Authored by jasonbcox on Sep 4 2020, 01:55.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC491ad850c4d0: Add check-source-control-tools build config
Summary

This adds the long-overdue build config for check-source-control-tools
which we should be running in CI.

Depends on D7324

Test Plan
./build-configurations.py check-source-control-tools

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Sep 4 2020, 01:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2020, 01:55
jasonbcox requested review of this revision.Sep 4 2020, 01:55
deadalnix accepted this revision.Sep 4 2020, 02:05
This revision is now accepted and ready to land.Sep 4 2020, 02:05
deadalnix added inline comments.Sep 4 2020, 02:06
contrib/teamcity/build-configurations.json
204 ↗(On Diff #23278)

As far as I can tell, this does not build any source control tool but instead as a test suite for them.

Harbormaster completed remote builds in B12609: Diff 23278.Sep 4 2020, 02:15
jasonbcox added a child revision: D7354: Fix running successive user builds when no artifacts are specified in build-configurations.json.Sep 4 2020, 02:21
jasonbcox added inline comments.Sep 4 2020, 16:13
contrib/teamcity/build-configurations.json
204 ↗(On Diff #23278)

Fair point.

jasonbcox edited the test plan for this revision. (Show Details)Sep 4 2020, 16:15
jasonbcox updated this revision to Diff 23296.Sep 4 2020, 16:15

build -> check per feedback

jasonbcox added a child revision: D7363: Clarify source control tools cmake flag.Sep 4 2020, 16:26
Harbormaster completed remote builds in B12621: Diff 23296.Sep 4 2020, 16:31
Closed by commit rABC491ad850c4d0: Add check-source-control-tools build config (authored by jasonbcox). · Explain WhySep 4 2020, 17:25
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC491ad850c4d0: Add check-source-control-tools build config.

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
9 lines

Diff 23300

View Options

contrib/teamcity/build-configurations.json

Loading...