Page MenuHomePhabricator

[CI] Don't mix configuration and builds steps
AbandonedPublic

Authored by Fabien on Sep 7 2020, 16:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

Currently the configuration step involves calling the build_cmake.sh
script and set the arguments so that it also builds the first group of
targets. But doing this discards the generator flags, making target
groups inconsistent against each other.
This diff always set the --no-build flag for the configure step and
build all the targets with the same flags.

Depends on D7380.

Test Plan

Run any CI build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ci_cmake_no_build
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12648
Build 25397: Build Diffbuild-clang-tidy · build-diff · build-clang-10 · build-without-wallet
Build 25396: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Sep 7 2020, 16:09
deadalnix requested changes to this revision.Sep 8 2020, 03:42
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
contrib/teamcity/build-configurations.py
154

When you build_cmake.sh script has a --nobuild flag, you know something is pretty fucked up somewhere and needs to be fixed.

Most likely; this script is doing random crap in addition of building. That random crap would be better off extracted from the script.

This revision now requires changes to proceed.Sep 8 2020, 03:42