Page MenuHomePhabricator

[CI] Don't call the build_cmake.sh script
ClosedPublic

Authored by Fabien on Sep 8 2020, 10:28.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC18f641fffd89: [CI] Don't call the build_cmake.sh script
Summary

The build_cmake.sh script is a wrapper that does 3 things:

  • it cleans the build directory
  • it runs cmake to configure the project
  • it runs ninja on the selected target, all by default

Since the CI build are migrating to descriptive builds, the last 2
pieces are now part of the configuration. The added value of the script
is only the call to git clean to clean the build directory.
This diffs make the builds defined fromt the configuration be
independent of the `build_cmake.sh' script. Once all the builds are
migrated, the wrapper can be completely removed.

Depends on D7380.

Test Plan
./contrib/teamcity/build-configurations.py build-asan

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Sep 8 2020, 10:28

This is a better option and supersedes D7383

This revision is now accepted and ready to land.Sep 8 2020, 11:55
This revision was automatically updated to reflect the committed changes.