Page MenuHomePhabricator
Differential D7395

[backport#14047 3/4] Add HKDF HMAC_SHA256 L=32 implementations
ClosedPublic
Actions

Authored by majcosta on Sep 8 2020, 14:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC5b38c54d2b81: [backport#14047 3/4] Add HKDF HMAC_SHA256 L=32 implementations
Summary

https://github.com/bitcoin/bitcoin/pull/14047/commits/551d489416339dae8f9d896013cd060a21406e2b

Depends on D7394

Partial backport of Core PR14047

Test Plan
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 8 2020, 14:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 8 2020, 14:42
majcosta requested review of this revision.Sep 8 2020, 14:42
teamcity edited the summary of this revision. (Show Details)Sep 8 2020, 14:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7396: [backport#14047 4/4] QA: add test for HKDF HMAC_SHA256 L32.Sep 8 2020, 14:43
Harbormaster completed remote builds in B12663: Diff 23374.Sep 8 2020, 14:53
deadalnix requested changes to this revision.Sep 8 2020, 22:21
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/crypto/hkdf_sha256_32.h
14 ↗(On Diff #23374)

Style

This revision now requires changes to proceed.Sep 8 2020, 22:21
majcosta updated this revision to Diff 23393.Sep 8 2020, 23:22

fixed style violation

Harbormaster completed remote builds in B12680: Diff 23393.Sep 8 2020, 23:36
deadalnix accepted this revision.Sep 9 2020, 00:26
This revision is now accepted and ready to land.Sep 9 2020, 00:26
Closed by commit rABC5b38c54d2b81: [backport#14047 3/4] Add HKDF HMAC_SHA256 L=32 implementations (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by majcosta). · Explain WhySep 9 2020, 00:39
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC5b38c54d2b81: [backport#14047 3/4] Add HKDF HMAC_SHA256 L=32 implementations.

Revision Contents
Changeset List

PathSize
src/
crypto/
1 line
28 lines
26 lines

Diff 23403

View Options

src/crypto/CMakeLists.txt

Loading...
View Options

src/crypto/hkdf_sha256_32.h

Loading...
View Options

src/crypto/hkdf_sha256_32.cpp

Loading...