Page MenuHomePhabricator
Differential D7399

Remove bigimg support and cleanup header
ClosedPublic
Actions

Authored by jasonbcox on Sep 8 2020, 16:35.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCWEB537866c203a9: Remove bigimg support and cleanup header
Summary

bigimg is not only not used, but the bigimg section is malformed HTML.
This patch cleans up and simplifies the header in preparation for migrating to flexbox.

Test Plan

make serve
Navigate to various pages and make sure nothing is broken.

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
cleanup-header
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12669
Build 25438: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Sep 8 2020, 16:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 8 2020, 16:35
jasonbcox requested review of this revision.Sep 8 2020, 16:35
Harbormaster completed remote builds in B12669: Diff 23380.Sep 8 2020, 16:35
jasonbcox updated this revision to Diff 23390.Sep 8 2020, 20:53

Remove big-img styles and init code (none of which are used)

Harbormaster completed remote builds in B12677: Diff 23390.Sep 8 2020, 20:53
jasonbcox retitled this revision from Cleanup header to Remove bigimg support and cleanup header.Sep 8 2020, 20:53
deadalnix accepted this revision.Sep 8 2020, 22:26
This revision is now accepted and ready to land.Sep 8 2020, 22:26
Closed by commit rABCWEB537866c203a9: Remove bigimg support and cleanup header (authored by jasonbcox). · Explain WhySep 8 2020, 23:30
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCWEB537866c203a9: Remove bigimg support and cleanup header.
jasonbcox added a child revision: D7410: Migrate all page content to flexbox.Sep 9 2020, 17:50

Revision Contents
Changeset List

PathSize
_includes/
94 lines

Diff 23380

View Options

_includes/header.html

Loading...