Page MenuHomePhabricator
Differential D7453

[backport#15699] Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly.
ClosedPublic
Actions

Authored by majcosta on Sep 16 2020, 14:17.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC248d01617451: [backport#15699] Remove no-op CClientUIInterface::[signal_name]_disconnect.
Summary

Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly. Remove no-op CClientUIInterface::[signal_name]_disconnect. (practicalswift)

Pull request description:

Resolves #15698.

Changes:
* Remove no-op `CClientUIInterface::[signal_name]_disconnect`.
* Disconnect `BlockNotifyGenesisWait` and `RPCNotifyBlockChange` properly.

Backport of Core PR15699

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Sep 16 2020, 14:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2020, 14:17
majcosta requested review of this revision.Sep 16 2020, 14:17
teamcity edited the summary of this revision. (Show Details)Sep 16 2020, 14:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12746: Diff 23509.Sep 16 2020, 14:36
deadalnix accepted this revision.Sep 16 2020, 15:21
This revision is now accepted and ready to land.Sep 16 2020, 15:21
Closed by commit rABC248d01617451: [backport#15699] Remove no-op CClientUIInterface::[signal_name]_disconnect. (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhySep 16 2020, 15:23
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC248d01617451: [backport#15699] Remove no-op CClientUIInterface::[signal_name]_disconnect..

Revision Contents
Changeset List

PathSize
src/
12 lines
3 lines
4 lines

Diff 23509

View Options

src/init.cpp

Loading...
View Options

src/ui_interface.h

Loading...
View Options

src/ui_interface.cpp

Loading...