Page MenuHomePhabricator

[lint] update expected circular dependencies
ClosedPublic

Authored by majcosta on Sep 16 2020, 17:33.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC24a8de1d3480: [lint] update expected circular dependencies
Summary

aserti3-2d introduced a couple circular deps, this accounts for them

Test Plan
./test/lint/lint-circular-dependencies.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
update_circular_dep_linter
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 12751
Build 25583: Build Diffbuild-clang-tidy · build-clang-10 · build-diff · build-without-wallet
Build 25582: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Sep 16 2020, 18:54
deadalnix added a subscriber: deadalnix.

How come arc lint didn't yell at us without this patch? Not really a change request, but this needs to be figure out.

This revision now requires changes to proceed.Sep 16 2020, 18:54

@bot build-tsan

deadalnix requested changes to this revision.Sep 18 2020, 23:20

This doesn't really answer the question.

This revision now requires changes to proceed.Sep 18 2020, 23:20

talked online, going to run this linter on CI

This revision is now accepted and ready to land.Wed, Sep 23, 00:20