[land-bot] Split land bot logic into distinct scripts
ClosedPublic
Actions

Authored by jasonbcox on Sep 16 2020, 23:58.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCe6059d542505: [land-bot] Split land bot logic into distinct scripts

Summary

This provides a much clearer division of responsibilities.
In so doing, land-patch.sh can be leveraged for both human-authored
revisions and automated commits. apply-revision.sh contains the
revision-specific pre-land logic that the land-bot runs as part of the
arc land-via-bot workflow.

Coincidentally, these pieces are both much easier to test by simply running
them locally.

Depends on D7455

Test Plan

Try applying some revision:

CONDUIT_TOKEN=<token> ./apply-revision.sh Dxxxx

This effectively only runs smoke tests at this time, but testing land-patch.sh
will become more relevant as autogen gets added:

git checkout master
git checkout <this-patch> land-patch.sh
./land-patch.sh --dry-run

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Sep 16 2020, 23:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2020, 23:58

jasonbcox requested review of this revision.Sep 16 2020, 23:58

jasonbcox edited the test plan for this revision. (Show Details)Sep 17 2020, 00:00

Harbormaster completed remote builds in B12762: Diff 23541.Sep 17 2020, 00:14

jasonbcox added a child revision: D7468: [land-bot] Add a sanity rebase after running smoke tests.Sep 17 2020, 00:24

deadalnix accepted this revision.Sep 17 2020, 13:04

This revision is now accepted and ready to land.Sep 17 2020, 13:04

jasonbcox added a child revision: D7476: [land-bot] Call land-patch when generating automated commits.Sep 17 2020, 15:59

deadalnix added inline comments.Sep 17 2020, 16:30

contrib/source-control-tools/apply-revision.sh
61 ↗	(On Diff #23541)	You'll note that this is probably redundant because arc land --hold will check for this. You might want to delete altogether and restructure this.