Page MenuHomePhabricator

[land-bot] Call land-patch when generating automated commits
ClosedPublic

Authored by jasonbcox on Sep 17 2020, 15:59.

Details

Summary

This decouples generation of automated commits from the landing logic.
land-patch.sh can be used to land the change generated from this script, so there
is no need to duplicate this logic here.

Depends on D7467

Test Plan
COMMIT_TYPE=archive-release-notes ./automated-commits.sh -p HEAD

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix requested changes to this revision.Sep 17 2020, 16:24
deadalnix added a subscriber: deadalnix.

This is doing exactly the wrong things. Instead of consolidating the framework in which automated commit happen, this instead consolidate the fact that there some kind of big ball of mud type script that can do every signle automated commit, but only half the workflow.

contrib/source-control-tools/automated-commits.sh
250 ↗(On Diff #23554)

You should be running the script that run the tests and land

This revision now requires changes to proceed.Sep 17 2020, 16:24

Remove all the refactoring and just call the land patch script

jasonbcox retitled this revision from [land-bot] Remove all landing logic from automated-commits script to [land-bot] Call land-patch when generating automated commits.Sep 17 2020, 17:02
jasonbcox edited the summary of this revision. (Show Details)
jasonbcox edited the test plan for this revision. (Show Details)

I' not sure why you would revert back other changes, there were not bad per se.

contrib/source-control-tools/automated-commits.sh
75 ↗(On Diff #23561)

That's a good way to defeat ccache.

This revision is now accepted and ready to land.Sep 17 2020, 17:10

I' not sure why you would revert back other changes, there were not bad per se.

Honestly some of them belong in their own patches. I shouldn't have done it that way to begin with because this patch as it is now is much easier to review.

contrib/source-control-tools/automated-commits.sh
75 ↗(On Diff #23561)

We do something similar for all of the CI builds as well. My understanding is the caching performs better if you know the cmake configuration is unlikely to change, and you can make this assumption by the build name. @Fabien can elaborate more on the details.

It's possible there's a smarter way to do this by running like-configuration builds in the same directory or something.