Page MenuHomePhabricator

Convert BitcoinAmountField to use Amount class
ClosedPublic

Authored by schancel on Dec 4 2017, 06:51.

Details

Summary

Depends on D747

Test Plan
  1. make check
  2. run src/qt/bitcoin-qt --testnet and try sending and receiving some transactions.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
qt-moc-field
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1245
Build 1245: arc lint + arc unit

Event Timeline

Remove erroneous comment

I do not think make check actually verify the GUI. Running the GUI on testnet and making a transaction there seems like a more appropriate test plan.

deadalnix requested changes to this revision.Dec 4 2017, 18:38
This revision now requires changes to proceed.Dec 4 2017, 18:38

It does run test_bitcoin-qt:

PASS: qt/test/test_bitcoin-qt

But you're right that it probably doesn't cover much. I'll see what I can do.

This revision is now accepted and ready to land.Dec 5 2017, 13:03
This revision was automatically updated to reflect the committed changes.