Decouple AUR patch recipe from the rest of the automated commits pipeline
ClosedPublic
Actions

Authored by jasonbcox on Sep 19 2020, 00:06.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCc3337e007433: Decouple AUR patch recipe from the rest of the automated commits pipeline

Summary

This is the first step to decoupling the commit generation logic
from the rest of the automation pipeline. Relevant feedback: https://reviews.bitcoinabc.org/D7479#177825
Once complete, the land bot logic that applies a revision will be no different
from any other commit generator.

Depends on D5808

Test Plan

This bails early and does not run smoke tests:

COMMIT_TYPE=dummy ./automated-commits.sh -p HEAD ./patch-recipes/update-aur-version.sh bitcoin-abc

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Sep 19 2020, 00:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 19 2020, 00:07

jasonbcox requested review of this revision.Sep 19 2020, 00:07

jasonbcox edited the summary of this revision. (Show Details)Sep 19 2020, 00:08

jasonbcox added a parent revision: D5808: [land-bot] Bail early if there's nothing to land.

Harbormaster completed remote builds in B12808: Diff 23600.Sep 19 2020, 00:26

deadalnix accepted this revision.Sep 19 2020, 13:31

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

contrib/source-control-tools/automated-commits.sh
15 ↗	(On Diff #23600)	You probably want to incentivize the use of `--`
contrib/source-control-tools/patch-recipes/update-aur-version.sh
13 ↗	(On Diff #23600)	It does not make sense to separate and crate a separate commit for each packages.