Page MenuHomePhabricator

Decouple AUR patch recipe from the rest of the automated commits pipeline
ClosedPublic

Authored by jasonbcox on Sep 19 2020, 00:06.

Details

Summary

This is the first step to decoupling the commit generation logic
from the rest of the automation pipeline. Relevant feedback: https://reviews.bitcoinabc.org/D7479#177825
Once complete, the land bot logic that applies a revision will be no different
from any other commit generator.

Depends on D5808

Test Plan

This bails early and does not run smoke tests:

COMMIT_TYPE=dummy ./automated-commits.sh -p HEAD ./patch-recipes/update-aur-version.sh bitcoin-abc

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
contrib/source-control-tools/automated-commits.sh
15 ↗(On Diff #23600)

You probably want to incentivize the use of --

contrib/source-control-tools/patch-recipes/update-aur-version.sh
13 ↗(On Diff #23600)

It does not make sense to separate and crate a separate commit for each packages.

This revision is now accepted and ready to land.Sep 19 2020, 13:31