[land-bot] Add an entry point for the land bot
AbandonedPublic
Actions

Authored by jasonbcox on Sep 17 2020, 18:35.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

This adds an single entry point for the revision land bot workflow.
The existing land bot job is already very similar to this patch, but it is
not under source control. Now that the implementation of the whole land
bot workflow is being refined, it makes sense to increase the visibility
of this behavior and continue iterating on it.

Depends on D7478

Test Plan

CONDUIT_TOKEN=<token> ./land-revision.sh --dry-run Dxxxx

Diff Detail

Repository

rABC Bitcoin ABC

Branch

lb-entrypoint

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12783
Build 25639: Build Diff	build-clang-10 · build-diff · build-clang-tidy · build-without-wallet
Build 25638: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Sep 17 2020, 18:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2020, 18:35

jasonbcox requested review of this revision.Sep 17 2020, 18:35

jasonbcox added a child revision: D7480: [land-bot] Cleanup unnecessary revision acceptable check.Sep 17 2020, 18:42

Harbormaster completed remote builds in B12779: Diff 23563.Sep 17 2020, 18:59

jasonbcox planned changes to this revision.Sep 17 2020, 19:28

jasonbcox edited the test plan for this revision. (Show Details)Sep 17 2020, 21:43

Rename the script to something more sensible

jasonbcox edited the test plan for this revision. (Show Details)Sep 17 2020, 21:44

Harbormaster completed remote builds in B12783: Diff 23569.Sep 17 2020, 22:03

Ok so you you ave something that goes roughly as

1/ Checkout and prepare the repository, makes sure it's all good.
2/ Get a patch from somewhere.
3/ Verify that the patch is good or at least not trivially broken.
4/ Push it.

Now, you got a pipeline that does this. Problem is, you baked step 3 in the existing pipeline, so now you are about to duplicate the whole pipeline because you have a use case that does something slightly different for step 3...

This revision now requires changes to proceed.Sep 18 2020, 00:56

jasonbcox mentioned this in D7490: Decouple AUR patch recipe from the rest of the automated commits pipeline.Sep 19 2020, 00:06

jasonbcox mentioned this in rABCc3337e007433: Decouple AUR patch recipe from the rest of the automated commits pipeline.Sep 21 2020, 17:03

jasonbcox mentioned this in D7503: [land-bot] Move apply-revision to patch recipes.Sep 21 2020, 23:04

jasonbcox abandoned this revision.Sep 21 2020, 23:37