Page MenuHomePhabricator

[land-bot] Add an entry point for the land bot
AbandonedPublic

Authored by jasonbcox on Sep 17 2020, 18:35.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This adds an single entry point for the revision land bot workflow.
The existing land bot job is already very similar to this patch, but it is
not under source control. Now that the implementation of the whole land
bot workflow is being refined, it makes sense to increase the visibility
of this behavior and continue iterating on it.

Depends on D7478

Test Plan
CONDUIT_TOKEN=<token> ./land-revision.sh --dry-run Dxxxx

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lb-entrypoint
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12779
Build 25631: Build Diffbuild-clang-tidy · build-without-wallet · build-diff · build-clang-10
Build 25630: arc lint + arc unit

Event Timeline

jasonbcox edited the test plan for this revision. (Show Details)

Rename the script to something more sensible

deadalnix requested changes to this revision.Sep 18 2020, 00:56
deadalnix added a subscriber: deadalnix.

Ok so you you ave something that goes roughly as

1/ Checkout and prepare the repository, makes sure it's all good.
2/ Get a patch from somewhere.
3/ Verify that the patch is good or at least not trivially broken.
4/ Push it.

Now, you got a pipeline that does this. Problem is, you baked step 3 in the existing pipeline, so now you are about to duplicate the whole pipeline because you have a use case that does something slightly different for step 3...

This revision now requires changes to proceed.Sep 18 2020, 00:56