Page MenuHomePhabricator

[CMAKE] Don't enable clang tidy on native builds
ClosedPublic

Authored by Fabien on Wed, Sep 23, 11:54.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC0f8fe6220df5: [CMAKE] Don't enable clang tidy on native builds
Summary

By definition, the native builds are not built using the compiler
specified to cmake, but with the system default. This makes it difficult
to use the clang-tidy option for the native builds, since the build
would fail if GCC is the system default.

Test Plan

With GCC as a system compiler:

cmake -GNinja .. \
  -DCMAKE_C_COMPILER=clang \
  -DCMAKE_CXX_COMPILER=clang++ \
  -DENABLE_CLANG_TIDY=ON
ninja all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.