Differential D7537

[CMAKE] Don't enable clang tidy on native builds
ClosedPublic
Actions

Authored by Fabien on Sep 23 2020, 11:54.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC0f8fe6220df5: [CMAKE] Don't enable clang tidy on native builds

Summary

By definition, the native builds are not built using the compiler
specified to cmake, but with the system default. This makes it difficult
to use the clang-tidy option for the native builds, since the build
would fail if GCC is the system default.

Test Plan

With GCC as a system compiler:

cmake -GNinja .. \
  -DCMAKE_C_COMPILER=clang \
  -DCMAKE_CXX_COMPILER=clang++ \
  -DENABLE_CLANG_TIDY=ON
ninja all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 23 2020, 11:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2020, 11:54

Fabien requested review of this revision.Sep 23 2020, 11:54

Fabien added a child revision: D7539: [CI] Update the clang-tidy build.Sep 23 2020, 11:59

Harbormaster completed remote builds in B12881: Diff 23725.Sep 23 2020, 12:02

majcosta accepted this revision.Sep 23 2020, 12:40

This revision is now accepted and ready to land.Sep 23 2020, 12:40

Closed by commit rABC0f8fe6220df5: [CMAKE] Don't enable clang tidy on native builds (authored by Fabien). · Explain WhySep 23 2020, 14:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0f8fe6220df5: [CMAKE] Don't enable clang tidy on native builds.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

3 lines

Diff 23733

View Options

[CMAKE] Don't enable clang tidy on native buildsClosedPublicActions