Page MenuHomePhabricator

Fix MacOS X build
ClosedPublic

Authored by schancel on Dec 5 2017, 23:31.

Details

Summary

Re-add includes for uint256.cpp and uint256.h into libbitcoin_consensus.a

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1251
Build 1251: arc lint + arc unit

Event Timeline

This causes uint256 to be linked in twice when using consensus and util libraries. This is a problem.

Fact. Can you please suggest an alternative?

Need to figure out how to deal with the need for these symbols in both libraries without including them twice.

schancel requested review of this revision.Dec 7 2017, 01:20
This revision is now accepted and ready to land.Dec 7 2017, 01:21
This revision was automatically updated to reflect the committed changes.