Page MenuHomePhabricator
Differential D7605

refactor: remove walletmodeltransaction circular dep
ClosedPublic
Actions

Authored by PiRK on Sep 28 2020, 14:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC4ff5a135d031: refactor: remove walletmodeltransaction circular dep
Summary

This conclude backport of PR17513
Commit 49c4211
Depends on D7603

Test Plan

ninja && ninja check
test/lint/lint-circular-dependencies.sh

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 28 2020, 14:45
Owners added a reviewer: Restricted Owners Package.Sep 28 2020, 14:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2020, 14:45
PiRK requested review of this revision.Sep 28 2020, 14:45
teamcity edited the summary of this revision. (Show Details)Sep 28 2020, 14:45

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12972: Diff 23882.Sep 28 2020, 14:56
deadalnix accepted this revision.Sep 28 2020, 15:31
This revision is now accepted and ready to land.Sep 28 2020, 15:31
PiRK edited the summary of this revision. (Show Details)Oct 1 2020, 11:31
PiRK added a parent revision: D7603: refactor: Cleanup headers from walletmodel.h.
Closed by commit rABC4ff5a135d031: refactor: remove walletmodeltransaction circular dep (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyOct 1 2020, 12:49
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4ff5a135d031: refactor: remove walletmodeltransaction circular dep.

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines
test/
lint/
1 line

Diff 24115

View Options

src/qt/walletmodeltransaction.h

Loading...
View Options

test/lint/lint-circular-dependencies.sh

Loading...