Page MenuHomePhabricator

remove walletmodel header in guiutil.cpp
AbandonedPublic

Authored by PiRK on Mon, Sep 28, 14:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Co-authored-by: Gregory Sanders <gsanders87@gmail.com>

Note: the corresponding commit in Core removes a circular dependency that was already removed on our side by D2814 and D5963.

This is part 4 of 5 of backport of Core PR17513
Depends on D7603

Test Plan

ninja && ninja check

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mon, Sep 28, 14:42
PiRK requested review of this revision.Mon, Sep 28, 14:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

PiRK retitled this revision from backport of PR17513 - part 4 to remove walletmodel header in guiutil.cpp.Mon, Sep 28, 14:50
deadalnix requested changes to this revision.Mon, Sep 28, 15:31
deadalnix added a subscriber: deadalnix.

It would be good to know why the circular dependency isn't removed. It looks like to me like it is as you removed qt/walletmodel from qt/guiutil

This revision now requires changes to proceed.Mon, Sep 28, 15:31

Actually that one seems to have been removed in D5963

"qt/guiutil -> qt/walletmodel -> qt/optionsmodel -> qt/guiutil"

It was probably solved by D2814 when the wallet.h was removed from optionsmodel.cpp.

I will update the revision text.

PiRK requested review of this revision.Thu, Oct 1, 09:58

Please link to the specific commit you are backporting when you are not porting the whole PR at once.

This revision is now accepted and ready to land.Thu, Oct 1, 10:43

This diff was merged into D7602