Page MenuHomePhabricator
Differential D7604

remove walletmodel header in guiutil.cpp
AbandonedPublic
Actions

Authored by PiRK on Sep 28 2020, 14:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Co-authored-by: Gregory Sanders <gsanders87@gmail.com>

Note: the corresponding commit in Core removes a circular dependency that was already removed on our side by D2814 and D5963.

This is part 4 of 5 of backport of Core PR17513
Depends on D7603

Test Plan

ninja && ninja check

Diff Detail

Event Timeline

PiRK created this revision.Sep 28 2020, 14:42
Owners added a reviewer: Restricted Owners Package.Sep 28 2020, 14:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2020, 14:42
PiRK requested review of this revision.Sep 28 2020, 14:42
teamcity edited the summary of this revision. (Show Details)Sep 28 2020, 14:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

PiRK added a child revision: D7605: refactor: remove walletmodeltransaction circular dep.Sep 28 2020, 14:45
PiRK retitled this revision from backport of PR17513 - part 4 to remove walletmodel header in guiutil.cpp.Sep 28 2020, 14:50
Harbormaster completed remote builds in B12971: Diff 23881.Sep 28 2020, 14:50
deadalnix requested changes to this revision.Sep 28 2020, 15:31
deadalnix added a subscriber: deadalnix.

It would be good to know why the circular dependency isn't removed. It looks like to me like it is as you removed qt/walletmodel from qt/guiutil

This revision now requires changes to proceed.Sep 28 2020, 15:31
PiRK added a comment.Sep 28 2020, 16:31

Actually that one seems to have been removed in D5963

"qt/guiutil -> qt/walletmodel -> qt/optionsmodel -> qt/guiutil"

It was probably solved by D2814 when the wallet.h was removed from optionsmodel.cpp.

I will update the revision text.

PiRK edited the summary of this revision. (Show Details)Sep 28 2020, 16:34
PiRK requested review of this revision.Oct 1 2020, 09:58
PiRK mentioned this in D7602: remove walletmodel circular dependency.Oct 1 2020, 10:15
deadalnix added a comment.Oct 1 2020, 10:43

Please link to the specific commit you are backporting when you are not porting the whole PR at once.

deadalnix accepted this revision.Oct 1 2020, 10:43
This revision is now accepted and ready to land.Oct 1 2020, 10:43
PiRK abandoned this revision.Oct 1 2020, 12:50

This diff was merged into D7602

Revision Contents
Changeset List

PathSize
src/
qt/
1 line

Diff 23881

View Options

src/qt/guiutil.cpp

Loading...