Page MenuHomePhabricator
Differential D7632

Check assumptions on integer implementation at compile time
ClosedPublic
Actions

Authored by deadalnix on Sep 29 2020, 09:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC35167d3d0d11: Check assumptions on integer implementation at compile time
Summary
  • Add support for (signed) __int128
  • Compile-time check assumptions on integer types

This is a backport of secp256k1 PR798

Test Plan
ninja check-secp256k1

Diff Detail

Event Timeline

deadalnix created this revision.Sep 29 2020, 09:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 09:41
deadalnix requested review of this revision.Sep 29 2020, 09:41
teamcity edited the summary of this revision. (Show Details)Sep 29 2020, 09:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Sep 29 2020, 09:46
This revision is now accepted and ready to land.Sep 29 2020, 09:46
deadalnix added a child revision: D7635: Add static assertion that uint32_t is unsigned int or wider.Sep 29 2020, 09:51
This revision was landed with ongoing or failed builds.Sep 29 2020, 09:55
Closed by commit rABC35167d3d0d11: Check assumptions on integer implementation at compile time (authored by Pieter Wuille <pieter@wuille.net>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC35167d3d0d11: Check assumptions on integer implementation at compile time.
Harbormaster completed remote builds in B13008: Diff 23948.Sep 29 2020, 09:56

Revision Contents
Changeset List

PathSize
src/
secp256k1/
5 lines
src/
74 lines
1 line
1 line
1 line
1 line
1 line
1 line

Diff 23948

View Options

src/secp256k1/Makefile.am

Loading...
View Options

src/secp256k1/src/assumptions.h

Loading...
View Options

src/secp256k1/src/bench_internal.c

Loading...
View Options

src/secp256k1/src/gen_context.c

Loading...
View Options

src/secp256k1/src/secp256k1.c

Loading...
View Options

src/secp256k1/src/tests_exhaustive.c

Loading...
View Options

src/secp256k1/src/util.h

Loading...
View Options

src/secp256k1/src/valgrind_ctime_test.c

Loading...