Page MenuHomePhabricator
Differential D7633

[SECP256K1] travis: Explicitly set --with-valgrind
ClosedPublic
Actions

Authored by Fabien on Sep 29 2020, 09:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC13ebc47995e2: [SECP256K1] travis: Explicitly set --with-valgrind
Summary
Also remove CPPFLAGS=-DVALGRIND because that's redundant with when
configured with --enable-valgrind.

Backport of secp256k1 PR821.

Test Plan

Run the Travis build.
https://travis-ci.org/github/Fabcien/secp256k1/builds/731225830

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 29 2020, 09:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 09:42
Fabien requested review of this revision.Sep 29 2020, 09:42
teamcity edited the summary of this revision. (Show Details)Sep 29 2020, 09:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien retitled this revision from travis: Explicitly set --with-valgrind to [SECP256K1] travis: Explicitly set --with-valgrind.Sep 29 2020, 09:43
deadalnix accepted this revision.Sep 29 2020, 09:53
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/secp256k1/travis/build_cmake.sh
58 ↗(On Diff #23949)

A bit out of scope, but I don't really see what this achieves. Shouldn't the thing compiled with valgrind and ctime tests for this is really be worth it?

This revision is now accepted and ready to land.Sep 29 2020, 09:53
This revision was landed with ongoing or failed builds.Sep 29 2020, 09:59
Closed by commit rABC13ebc47995e2: [SECP256K1] travis: Explicitly set --with-valgrind (authored by Jonas Nick <jonasd.nick@gmail.com>, committed by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC13ebc47995e2: [SECP256K1] travis: Explicitly set --with-valgrind.
Harbormaster completed remote builds in B13009: Diff 23949.Sep 29 2020, 10:22
Fabien mentioned this in D7661: [SECP256K1] Fix some travis issues on macOS.Sep 29 2020, 12:49
Fabien mentioned this in rABCa83300b50841: [SECP256K1] Fix some travis issues on macOS.Sep 29 2020, 13:08

Revision Contents
Changeset List

PathSize
src/
secp256k1/
15 lines
travis/
5 lines
2 lines

Diff 23954

View Options

src/secp256k1/.travis.yml

Loading...
View Options

src/secp256k1/travis/build_autotools.sh

Loading...
View Options

src/secp256k1/travis/build_cmake.sh

Loading...