Page MenuHomePhabricator

[SECP256K1] travis: Explicitly set --with-valgrind
ClosedPublic

Authored by Fabien on Sep 29 2020, 09:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC13ebc47995e2: [SECP256K1] travis: Explicitly set --with-valgrind
Summary
Also remove CPPFLAGS=-DVALGRIND because that's redundant with when
configured with --enable-valgrind.

Backport of secp256k1 PR821.

Test Plan

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Sep 29 2020, 09:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien retitled this revision from travis: Explicitly set --with-valgrind to [SECP256K1] travis: Explicitly set --with-valgrind.Sep 29 2020, 09:43
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/secp256k1/travis/build_cmake.sh
58 ↗(On Diff #23949)

A bit out of scope, but I don't really see what this achieves. Shouldn't the thing compiled with valgrind and ctime tests for this is really be worth it?

This revision is now accepted and ready to land.Sep 29 2020, 09:53
This revision was landed with ongoing or failed builds.Sep 29 2020, 09:59
This revision was automatically updated to reflect the committed changes.