Page MenuHomePhabricator
Differential D7646

schnorrsig: Init empty experimental module
ClosedPublic
Actions

Authored by deadalnix on Sep 29 2020, 10:58.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7cf7dc459e8f: schnorrsig: Init empty experimental module
Summary

This is a partial backport of secp256k1 PR558 : https://github.com/bitcoin-core/secp256k1/pull/558/commits/7a703fd97db0161bae07ef84513ddde6e0d27353

Test Plan
ninja check-secp256k1

With missing extrakeys:

cmake -GNinja .. -DSECP256K1_ENABLE_MODULE_SCHNORRSIG=On

Check that we get an error.

And with the module:

cmake -GNinja .. -DSECP256K1_ENABLE_MODULE_EXTRAKEYS=On -DSECP256K1_ENABLE_MODULE_SCHNORRSIG=On
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 29 2020, 10:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 10:58
deadalnix requested review of this revision.Sep 29 2020, 10:58
teamcity edited the summary of this revision. (Show Details)Sep 29 2020, 10:58

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix updated this revision to Diff 23975.Sep 29 2020, 11:01

better cmake handling

deadalnix edited the test plan for this revision. (Show Details)Sep 29 2020, 11:01
deadalnix added a child revision: D7647: schnorrsig: Add BIP-340 nonce function.Sep 29 2020, 11:09
Harbormaster completed remote builds in B13025: Diff 23974.Sep 29 2020, 11:38
Harbormaster completed remote builds in B13026: Diff 23975.
Fabien accepted this revision.Sep 29 2020, 11:54
This revision is now accepted and ready to land.Sep 29 2020, 11:54
Closed by commit rABC7cf7dc459e8f: schnorrsig: Init empty experimental module (authored by Jonas Nick <jonasd.nick@gmail.com>, committed by deadalnix). · Explain WhySep 29 2020, 12:03
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC7cf7dc459e8f: schnorrsig: Init empty experimental module.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
10 lines
4 lines
22 lines
include/
17 lines
src/
modules/
schnorrsig/
3 lines
16 lines
17 lines
4 lines
8 lines

Diff 23986

View Options

src/secp256k1/CMakeLists.txt

Loading...
View Options

src/secp256k1/Makefile.am

Loading...
View Options

src/secp256k1/configure.ac

Loading...
View Options

src/secp256k1/include/secp256k1_schnorrsig.h

Loading...
View Options

src/secp256k1/src/modules/schnorrsig/Makefile.am.include

Loading...
View Options

src/secp256k1/src/modules/schnorrsig/main_impl.h

Loading...
View Options

src/secp256k1/src/modules/schnorrsig/tests_impl.h

Loading...
View Options

src/secp256k1/src/secp256k1.c

Loading...
View Options

src/secp256k1/src/tests.c

Loading...