Page MenuHomePhabricator
Differential D7653

Enable -Wundef warning
ClosedPublic
Actions

Authored by deadalnix on Sep 29 2020, 11:45.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6c1ecb7dae8e: Enable -Wundef warning
Summary

This is a backport of secp256k1 PR819

Depends on D7651

Test Plan
ninja all check-secp256k1 bench-secp256k1

Check there are no warnings.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 29 2020, 11:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 11:45
deadalnix requested review of this revision.Sep 29 2020, 11:45
teamcity edited the summary of this revision. (Show Details)Sep 29 2020, 11:45

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13033: Diff 23985.Sep 29 2020, 12:03
deadalnix edited the summary of this revision. (Show Details)Sep 29 2020, 12:12
deadalnix added a parent revision: D7651: valgrind_ctime_test: Add schnorrsig_sign.
deadalnix updated this revision to Diff 23992.Sep 29 2020, 12:13

rebase

Fabien requested changes to this revision.Sep 29 2020, 12:14
Fabien added a subscriber: Fabien.

Add the flag to the CMakeLists.txt as well

This revision now requires changes to proceed.Sep 29 2020, 12:14
deadalnix updated this revision to Diff 23994.Sep 29 2020, 12:38

Add cmake

Fabien accepted this revision.Sep 29 2020, 12:43
This revision is now accepted and ready to land.Sep 29 2020, 12:43
Harbormaster completed remote builds in B13034: Diff 23992.Sep 29 2020, 12:43
This revision was landed with ongoing or failed builds.Sep 29 2020, 12:45
Closed by commit rABC6c1ecb7dae8e: Enable -Wundef warning (authored by Tim Ruffing <crypto@timruffing.de>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC6c1ecb7dae8e: Enable -Wundef warning.
Harbormaster completed remote builds in B13035: Diff 23994.Sep 29 2020, 12:50

Revision Contents
Changeset List

PathSize
src/
secp256k1/
1 line
2 lines
src/
22 lines

Diff 23999

View Options

src/secp256k1/CMakeLists.txt

Loading...
View Options

src/secp256k1/configure.ac

Loading...
View Options

src/secp256k1/src/valgrind_ctime_test.c

Loading...