Merge #16293: test: Make test cases separate functions
ClosedPublic
Actions

Authored by jasonbcox on Sep 30 2020, 21:11.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCd54de8344d7a: Merge #16293: test: Make test cases separate functions

Summary

faf8318c55a6001270a6fc8ed2298767099bafba test: Split fundrawtx test into subtests (MarcoFalke)
fa6fba3bc8013d7f813edd71f152d86eab907e4d test: Make local symbols in run_test members (MarcoFalke)

Pull request description:

This prevents scope-leak of symbols that are supposed to be local to one test case.

Top commit has no ACKs.

Backport of Core PR16293

Test Plan

test_runner.py rpc_fundrawtransaction

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Sep 30 2020, 21:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2020, 21:11

jasonbcox requested review of this revision.Sep 30 2020, 21:11

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13081: Diff 24073.Sep 30 2020, 21:25

jasonbcox edited the summary of this revision. (Show Details)Sep 30 2020, 21:34

Please clean up those hashes from the summary. Sometimes they collide with PR numbers when grepping and it's annoying.

test/functional/rpc_fundrawtransaction.py
779 ↗	(On Diff #24073)	since you're on it, might as well put this one into its own line as well
786 ↗	(On Diff #24073)	there's a comma missing between `)` and `]`