Page MenuHomePhabricator
Differential D7688

Merge #16293: test: Make test cases separate functions
ClosedPublic
Actions

Authored by jasonbcox on Sep 30 2020, 21:11.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCd54de8344d7a: Merge #16293: test: Make test cases separate functions
Summary

faf8318c55a6001270a6fc8ed2298767099bafba test: Split fundrawtx test into subtests (MarcoFalke)
fa6fba3bc8013d7f813edd71f152d86eab907e4d test: Make local symbols in run_test members (MarcoFalke)

Pull request description:

This prevents scope-leak of symbols that are supposed to be local to one test case.

Top commit has no ACKs.

Backport of Core PR16293

Test Plan

test_runner.py rpc_fundrawtransaction

Diff Detail

Event Timeline

jasonbcox created this revision.Sep 30 2020, 21:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2020, 21:11
jasonbcox requested review of this revision.Sep 30 2020, 21:11
teamcity edited the summary of this revision. (Show Details)Sep 30 2020, 21:12

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13081: Diff 24073.Sep 30 2020, 21:25
jasonbcox edited the summary of this revision. (Show Details)Sep 30 2020, 21:34
majcosta requested changes to this revision.Sep 30 2020, 21:38
majcosta added a subscriber: majcosta.

Please clean up those hashes from the summary. Sometimes they collide with PR numbers when grepping and it's annoying.

test/functional/rpc_fundrawtransaction.py
779

since you're on it, might as well put this one into its own line as well

786

there's a comma missing between ) and ]

This revision now requires changes to proceed.Sep 30 2020, 21:38
jasonbcox updated this revision to Diff 24077.Sep 30 2020, 22:02

Fixed according to feedback

majcosta accepted this revision.Sep 30 2020, 22:03
This revision is now accepted and ready to land.Sep 30 2020, 22:03
jasonbcox added a child revision: D7691: Merge #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs.Sep 30 2020, 22:07
Harbormaster completed remote builds in B13084: Diff 24077.Sep 30 2020, 22:30
Closed by commit rABCd54de8344d7a: Merge #16293: test: Make test cases separate functions (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhySep 30 2020, 22:31
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCd54de8344d7a: Merge #16293: test: Make test cases separate functions.

Revision Contents
Changeset List

PathSize
test/
functional/
179 lines

Diff 24073

View Options

test/functional/rpc_fundrawtransaction.py

Loading...