Differential D7694
[backport#17518] refactor, wallet: Nuke coincontrol circular dependency Authored by majcosta on Sep 30 2020, 23:46. Tags None Subscribers None
Details
3ed5e6819a50434449d92cb96b9d8d141e8c7d2b refactor: Nuke coincontrol circular dependency (Hennadii Stepanov) Pull request description: This PR gets rid of `wallet/coincontrol` -> `wallet/wallet` -> `wallet/coincontrol` circular dependency. Backport of Core PR17518 ninja check check-functional
Diff Detail
Event TimelineComment Actions [Bot Message] Comment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Snippet of first build failure: [342/402] bitcoin: testing streams_tests [343/402] bitcoin: testing timedata_tests [344/402] Running utility command for check-bitcoin-streams_tests [345/402] Running utility command for check-bitcoin-timedata_tests [346/402] bitcoin: testing uint256_tests [347/402] Running utility command for check-bitcoin-uint256_tests [348/402] bitcoin: testing undo_tests [349/402] Running utility command for check-bitcoin-undo_tests [350/402] bitcoin: testing walletdb_tests [351/402] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o [352/402] bitcoin: testing serialize_tests [353/402] bitcoin: testing util_threadnames_tests [354/402] Running utility command for check-bitcoin-walletdb_tests [355/402] Running utility command for check-bitcoin-serialize_tests [356/402] Running utility command for check-bitcoin-util_threadnames_tests [357/402] bitcoin: testing validationinterface_tests [358/402] bitcoin: testing radix_tests [359/402] Running utility command for check-bitcoin-validationinterface_tests [360/402] Running utility command for check-bitcoin-radix_tests [361/402] bitcoin: testing script_standard_tests [362/402] Running utility command for check-bitcoin-script_standard_tests [363/402] bitcoin: testing blockcheck_tests [364/402] bitcoin: testing crypto_tests [365/402] Running utility command for check-bitcoin-blockcheck_tests [366/402] Running utility command for check-bitcoin-crypto_tests [367/402] bitcoin: testing ismine_tests [368/402] bitcoin: testing blockstatus_tests [369/402] Running utility command for check-bitcoin-ismine_tests [370/402] Running utility command for check-bitcoin-blockstatus_tests [371/402] bitcoin: testing versionbits_tests [372/402] Running utility command for check-bitcoin-versionbits_tests [373/402] bitcoin: testing cashaddr_tests [374/402] Running utility command for check-bitcoin-cashaddr_tests [375/402] bitcoin: testing getarg_tests [376/402] Running utility command for check-bitcoin-getarg_tests [377/402] bitcoin: testing script_tests [378/402] bitcoin: testing bswap_tests [379/402] Running utility command for check-bitcoin-script_tests [380/402] Running utility command for check-bitcoin-bswap_tests [381/402] bitcoin: testing validation_tests [382/402] Running utility command for check-bitcoin-validation_tests [383/402] bitcoin: testing skiplist_tests [384/402] Running utility command for check-bitcoin-skiplist_tests [385/402] bitcoin: testing validation_block_tests [386/402] Running utility command for check-bitcoin-validation_block_tests [387/402] bitcoin: testing transaction_tests [388/402] Running utility command for check-bitcoin-transaction_tests [389/402] Linking CXX executable src/qt/test/test_bitcoin-qt [390/402] bitcoin: testing util_tests [391/402] Running utility command for check-bitcoin-util_tests [392/402] bitcoin: testing cuckoocache_tests [393/402] Running utility command for check-bitcoin-cuckoocache_tests [394/402] bitcoin: testing op_reversebytes_tests [395/402] Running utility command for check-bitcoin-op_reversebytes_tests [396/402] bitcoin: testing coins_tests [397/402] Running utility command for check-bitcoin-coins_tests [398/402] bitcoin-qt: testing test_bitcoin-qt [399/402] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite Build build-clang-tidy timed out after 1800.0s Comment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Snippet of first build failure: [350/409] Running utility command for check-bitcoin-streams_tests [351/409] Running utility command for check-bitcoin-settings_tests [352/409] bitcoin: testing timedata_tests [353/409] Running utility command for check-bitcoin-timedata_tests [354/409] bitcoin: testing uint256_tests [355/409] Running utility command for check-bitcoin-uint256_tests [356/409] bitcoin: testing sigencoding_tests [357/409] bitcoin: testing walletdb_tests [358/409] Running utility command for check-bitcoin-sigencoding_tests [359/409] Running utility command for check-bitcoin-walletdb_tests [360/409] bitcoin: testing undo_tests [361/409] Running utility command for check-bitcoin-undo_tests [362/409] bitcoin: testing serialize_tests [363/409] bitcoin: testing util_threadnames_tests [364/409] Running utility command for check-bitcoin-serialize_tests [365/409] Running utility command for check-bitcoin-util_threadnames_tests [366/409] bitcoin: testing radix_tests [367/409] Running utility command for check-bitcoin-radix_tests [368/409] bitcoin: testing script_standard_tests [369/409] bitcoin: testing blockcheck_tests [370/409] Running utility command for check-bitcoin-script_standard_tests [371/409] Running utility command for check-bitcoin-blockcheck_tests [372/409] bitcoin: testing crypto_tests [373/409] Running utility command for check-bitcoin-crypto_tests [374/409] bitcoin: testing blockstatus_tests [375/409] bitcoin: testing ismine_tests [376/409] bitcoin: testing versionbits_tests [377/409] Running utility command for check-bitcoin-blockstatus_tests [378/409] Running utility command for check-bitcoin-ismine_tests [379/409] Running utility command for check-bitcoin-versionbits_tests [380/409] bitcoin: testing script_tests [381/409] bitcoin: testing cashaddr_tests [382/409] bitcoin: testing validation_block_tests [383/409] Running utility command for check-bitcoin-script_tests [384/409] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite [385/409] Running utility command for check-bitcoin-cashaddr_tests [386/409] bitcoin: testing validation_tests [387/409] Running utility command for check-bitcoin-validation_block_tests [388/409] Running utility command for check-bitcoin-validation_tests [389/409] bitcoin: testing getarg_tests [390/409] bitcoin: testing bswap_tests [391/409] Running utility command for check-bitcoin-bswap_tests [392/409] Running utility command for check-bitcoin-getarg_tests [393/409] bitcoin: testing skiplist_tests [394/409] Running utility command for check-bitcoin-skiplist_tests [395/409] bitcoin: testing util_tests [396/409] Running utility command for check-bitcoin-util_tests [397/409] bitcoin: testing cuckoocache_tests [398/409] Running utility command for check-bitcoin-cuckoocache_tests [399/409] bitcoin: testing op_reversebytes_tests [400/409] Running utility command for check-bitcoin-op_reversebytes_tests [401/409] bitcoin: testing coins_tests [402/409] Running utility command for check-bitcoin-coins_tests [403/409] bitcoin: testing transaction_tests [404/409] Running utility command for check-bitcoin-transaction_tests [405/409] secp256k1: testing secp256k1-tests [406/409] Running secp256k1 test suite PASSED: secp256k1 test suite Build build-clang timed out after 1200.0s |