Page MenuHomePhabricator

wallet: Avoid translating RPC errors when creating txs
ClosedPublic

Authored by deadalnix on Oct 1 2020, 13:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfd902a90a6a2: wallet: Avoid translating RPC errors when creating txs
Summary

Also, mark feebumper bilingual_str as Untranslated

They are technical and have previously not been translated either.
It is questionable whether they can even appear in the GUI.

This is a partial backport of Cor PR18699 : https://github.com/bitcoin/bitcoin/pull/18699/commits/fae7776690c37104d2d4949429c5f84e6a33c576

Test Plan
ninja all check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Oct 1 2020, 13:41
This revision was landed with ongoing or failed builds.Oct 1 2020, 14:15
This revision was automatically updated to reflect the committed changes.

Snippet of first build failure:

[341/402] Running utility command for check-bitcoin-torcontrol_tests
[342/402] bitcoin: testing settings_tests
[343/402] Running utility command for check-bitcoin-settings_tests
[344/402] bitcoin: testing timedata_tests
[345/402] bitcoin: testing streams_tests
[346/402] Running utility command for check-bitcoin-timedata_tests
[347/402] Running utility command for check-bitcoin-streams_tests
[348/402] bitcoin: testing uint256_tests
[349/402] bitcoin: testing checkqueue_tests
[350/402] Running utility command for check-bitcoin-checkqueue_tests
[351/402] Running utility command for check-bitcoin-uint256_tests
[352/402] bitcoin: testing undo_tests
[353/402] Running utility command for check-bitcoin-undo_tests
[354/402] bitcoin: testing walletdb_tests
[355/402] Running utility command for check-bitcoin-walletdb_tests
[356/402] bitcoin: testing util_threadnames_tests
[357/402] bitcoin: testing validationinterface_tests
[358/402] Running utility command for check-bitcoin-util_threadnames_tests
[359/402] bitcoin: testing serialize_tests
[360/402] Running utility command for check-bitcoin-serialize_tests
[361/402] Running utility command for check-bitcoin-validationinterface_tests
[362/402] bitcoin: testing blockcheck_tests
[363/402] bitcoin: testing script_standard_tests
[364/402] Running utility command for check-bitcoin-blockcheck_tests
[365/402] Running utility command for check-bitcoin-script_standard_tests
[366/402] bitcoin: testing blockstatus_tests
[367/402] bitcoin: testing radix_tests
[368/402] Running utility command for check-bitcoin-radix_tests
[369/402] Running utility command for check-bitcoin-blockstatus_tests
[370/402] bitcoin: testing crypto_tests
[371/402] bitcoin: testing ismine_tests
[372/402] Running utility command for check-bitcoin-crypto_tests
[373/402] Running utility command for check-bitcoin-ismine_tests
[374/402] bitcoin: testing cashaddr_tests
[375/402] bitcoin: testing versionbits_tests
[376/402] Running utility command for check-bitcoin-cashaddr_tests
[377/402] bitcoin: testing getarg_tests
[378/402] Running utility command for check-bitcoin-versionbits_tests
[379/402] Running utility command for check-bitcoin-getarg_tests
[380/402] bitcoin: testing bswap_tests
[381/402] Running utility command for check-bitcoin-bswap_tests
[382/402] bitcoin: testing validation_tests
[383/402] bitcoin: testing script_tests
[384/402] Running utility command for check-bitcoin-script_tests
[385/402] Running utility command for check-bitcoin-validation_tests
[386/402] bitcoin: testing validation_block_tests
[387/402] bitcoin: testing skiplist_tests
[388/402] Running utility command for check-bitcoin-validation_block_tests
[389/402] Running utility command for check-bitcoin-skiplist_tests
[390/402] bitcoin: testing transaction_tests
[391/402] Running utility command for check-bitcoin-transaction_tests
[392/402] bitcoin: testing util_tests
[393/402] Running utility command for check-bitcoin-util_tests
[394/402] bitcoin: testing op_reversebytes_tests
[395/402] Running utility command for check-bitcoin-op_reversebytes_tests
[396/402] bitcoin: testing cuckoocache_tests
[397/402] Running utility command for check-bitcoin-cuckoocache_tests
[398/402] bitcoin: testing coins_tests
[399/402] Running utility command for check-bitcoin-coins_tests
Build build-clang-tidy timed out after 1800.0s