Page MenuHomePhabricator
Differential D7708

wallet: Remove trailing whitespace from potential translation strings
ClosedPublic
Actions

Authored by deadalnix on Oct 1 2020, 14:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe3f1ac00d451: wallet: Remove trailing whitespace from potential translation strings
Summary

If the potential translation strings are translated in the future,
trailing whitespace is going to make translation effort harder.

This is the final part of Core PR18699 : https://github.com/bitcoin/bitcoin/pull/18699/commits/fa2cce4391b0b1bda325f695bb45f7b565c8e8ea

Depends on D7707

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 1 2020, 14:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2020, 14:08
deadalnix requested review of this revision.Oct 1 2020, 14:08
teamcity edited the summary of this revision. (Show Details)Oct 1 2020, 14:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Oct 1 2020, 14:22
This revision is now accepted and ready to land.Oct 1 2020, 14:22
This revision was landed with ongoing or failed builds.Oct 1 2020, 14:33
Closed by commit rABCe3f1ac00d451: wallet: Remove trailing whitespace from potential translation strings (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCe3f1ac00d451: wallet: Remove trailing whitespace from potential translation strings.
Harbormaster completed remote builds in B13113: Diff 24128.Oct 1 2020, 14:49
teamcity added a comment.Oct 1 2020, 14:49
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

OK
[114/373] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:541:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {
                      ^~~~~~~~~~~~
[153/373] Running seeder test suite
PASSED: seeder test suite
[159/373] Running avalanche test suite
PASSED: avalanche test suite
[345/373] Running pow test suite
PASSED: pow test suite
[370/373] Running bitcoin test suite
PASSED: bitcoin test suite
[372/373] bitcoin-qt: testing test_bitcoin-qt
FAILED: src/qt/test/CMakeFiles/check-bitcoin-qt-test_bitcoin-qt 
cd /work/abc-ci-builds/build-without-wallet/src/qt/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-qt-test_bitcoin-qt.log /work/abc-ci-builds/build-without-wallet/src/qt/test/test_bitcoin-qt
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
********* Start testing of AppTests *********
Config: Using QtTest library 5.11.3, Qt 5.11.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 8.3.0)
PASS   : AppTests::initTestCase()
QWARN  : AppTests::appTests() Backing up GUI settings to "/tmp/test_common_Bitcoin ABC/1601563424_724745641/regtest/guisettings.ini.bak"
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QDEBUG : AppTests::appTests() requestInitialize : Requesting initialize
QDEBUG : AppTests::appTests() initialize : Running initialization in thread
QDEBUG : AppTests::appTests() initializeResult : Initialization result:  true
QWARN  : AppTests::appTests() Platform customization: "other"
QWARN  : AppTests::appTests() This plugin does not support propagateSizeHints()
QWARN  : AppTests::appTests() This plugin does not support raise()
QWARN  : AppTests::appTests() This plugin does not support grabbing the keyboard
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() QFont::setPointSizeF: Point size <= 0 (-1.000000), must be greater than 0
QWARN  : AppTests::appTests() This plugin does not support propagateSizeHints()
QDEBUG : AppTests::appTests() requestShutdown : Requesting shutdown
QDEBUG : AppTests::appTests() shutdown : Running Shutdown in thread

=== Received signal at function time: 300008ms, total time: 300009ms, dumping stack ===
=== End of stack trace ===
QFATAL : AppTests::appTests() Test function timed out
FAIL!  : AppTests::appTests() Received a fatal error.
   Loc: [Unknown file(0)]
Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted, 300014ms
********* Finished testing of AppTests *********
Aborted (core dumped)
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Oct 1 2020, 15:01
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Snippet of first build failure:

[350/409] bitcoin: testing timedata_tests
[351/409] bitcoin: testing streams_tests
[352/409] Running utility command for check-bitcoin-timedata_tests
[353/409] Running utility command for check-bitcoin-streams_tests
[354/409] bitcoin: testing uint256_tests
[355/409] Running utility command for check-bitcoin-uint256_tests
[356/409] bitcoin: testing walletdb_tests
[357/409] Running utility command for check-bitcoin-walletdb_tests
[358/409] bitcoin: testing undo_tests
[359/409] bitcoin: testing sigencoding_tests
[360/409] Running utility command for check-bitcoin-undo_tests
[361/409] Running utility command for check-bitcoin-sigencoding_tests
[362/409] bitcoin: testing util_threadnames_tests
[363/409] Running utility command for check-bitcoin-util_threadnames_tests
[364/409] bitcoin: testing serialize_tests
[365/409] Running utility command for check-bitcoin-serialize_tests
[366/409] bitcoin: testing script_standard_tests
[367/409] Running utility command for check-bitcoin-script_standard_tests
[368/409] bitcoin: testing radix_tests
[369/409] Running utility command for check-bitcoin-radix_tests
[370/409] bitcoin: testing crypto_tests
[371/409] bitcoin: testing blockstatus_tests
[372/409] Running utility command for check-bitcoin-crypto_tests
[373/409] Running utility command for check-bitcoin-blockstatus_tests
[374/409] bitcoin: testing blockcheck_tests
[375/409] Running utility command for check-bitcoin-blockcheck_tests
[376/409] bitcoin: testing validation_tests
[377/409] bitcoin: testing validation_block_tests
[378/409] bitcoin: testing versionbits_tests
[379/409] Running utility command for check-bitcoin-versionbits_tests
[380/409] Running utility command for check-bitcoin-validation_tests
[381/409] Running utility command for check-bitcoin-validation_block_tests
[382/409] bitcoin: testing ismine_tests
[383/409] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[384/409] bitcoin: testing cashaddr_tests
[385/409] Running utility command for check-bitcoin-ismine_tests
[386/409] Running utility command for check-bitcoin-cashaddr_tests
[387/409] bitcoin: testing script_tests
[388/409] bitcoin: testing getarg_tests
[389/409] Running utility command for check-bitcoin-script_tests
[390/409] bitcoin: testing bswap_tests
[391/409] Running utility command for check-bitcoin-getarg_tests
[392/409] Running utility command for check-bitcoin-bswap_tests
[393/409] bitcoin: testing skiplist_tests
[394/409] Running utility command for check-bitcoin-skiplist_tests
[395/409] bitcoin: testing util_tests
[396/409] Running utility command for check-bitcoin-util_tests
[397/409] bitcoin: testing cuckoocache_tests
[398/409] Running utility command for check-bitcoin-cuckoocache_tests
[399/409] bitcoin: testing op_reversebytes_tests
[400/409] Running utility command for check-bitcoin-op_reversebytes_tests
[401/409] bitcoin: testing coins_tests
[402/409] Running utility command for check-bitcoin-coins_tests
[403/409] bitcoin: testing transaction_tests
[404/409] Running utility command for check-bitcoin-transaction_tests
[405/409] secp256k1: testing secp256k1-tests
[406/409] Running secp256k1 test suite
PASSED: secp256k1 test suite
Build build-clang timed out after 1200.0s

Revision Contents
Changeset List

PathSize
src/
wallet/
6 lines
test/
functional/
23 lines

Diff 24136

View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...