Page MenuHomePhabricator
Differential D7739

Document assumptions about compiler, add sizeof(size_t) assumptions
ClosedPublic
Actions

Authored by PiRK on Oct 2 2020, 12:12.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC418fdfff8579: Document assumptions about compiler, add sizeof(size_t) assumptions
Summary

Backport of Core PR15522

Test Plan

ninja

Diff Detail

Event Timeline

PiRK created this revision.Oct 2 2020, 12:12
Owners added a reviewer: Restricted Owners Package.Oct 2 2020, 12:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2020, 12:12
PiRK requested review of this revision.Oct 2 2020, 12:12
teamcity edited the summary of this revision. (Show Details)Oct 2 2020, 12:13

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13155: Diff 24204.Oct 2 2020, 12:18
deadalnix requested changes to this revision.Oct 2 2020, 14:19
deadalnix added subscribers: Fabien, deadalnix.
deadalnix added inline comments.
src/compat/assumptions.h
32 ↗(On Diff #24204)

Aren't we assuming C++14 already?

@Fabien ?

This revision now requires changes to proceed.Oct 2 2020, 14:19
Fabien added inline comments.Oct 7 2020, 07:32
src/compat/assumptions.h
32 ↗(On Diff #24204)

Yes

PiRK updated this revision to Diff 24325.Oct 7 2020, 07:45

assume C++14 instead of C++11

PiRK updated this revision to Diff 24326.Oct 7 2020, 07:49

update also comment

Harbormaster completed remote builds in B13228: Diff 24325.Oct 7 2020, 08:05
Harbormaster completed remote builds in B13229: Diff 24326.Oct 7 2020, 08:13
Fabien added inline comments.Oct 7 2020, 08:19
src/compat/assumptions.h
25 ↗(On Diff #24326)

Spurious smiley ?
If you want c++14 examples, we use std::make_unique() through the codebase

PiRK marked an inline comment as done.Oct 7 2020, 08:37
PiRK updated this revision to Diff 24330.Oct 7 2020, 08:37

add example, fix comment formatting, remove smiley from comment

Fabien accepted this revision.Oct 7 2020, 08:42
Harbormaster completed remote builds in B13232: Diff 24330.Oct 7 2020, 08:58
deadalnix accepted this revision.Oct 7 2020, 18:39
This revision is now accepted and ready to land.Oct 7 2020, 18:39
Closed by commit rABC418fdfff8579: Document assumptions about compiler, add sizeof(size_t) assumptions (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by PiRK). · Explain WhyOct 8 2020, 04:15
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC418fdfff8579: Document assumptions about compiler, add sizeof(size_t) assumptions.

Revision Contents
Changeset List

PathSize
src/
compat/
22 lines

Diff 24325

View Options

src/compat/assumptions.h

Loading...