Differential D7741

windows: Set _WIN32_WINNT to 0x0601 (Windows 7)
ClosedPublic
Actions

Authored by Fabien on Oct 2 2020, 13:38.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCb969a5330c13: windows: Set _WIN32_WINNT to 0x0601 (Windows 7)

Summary

Was set to 0x0501 (XP) which is no longer supported.

Backport of core PR14922.

Test Plan

cmake -GNinja ..\
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake \
  -DBUILD_BITCOIN_SEEDER=OFF
ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14922

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13157
Build 26364: Build Diff	lint-circular-dependencies · build-diff · build-clang-tidy · build-without-wallet · build-clang
Build 26363: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 2 2020, 13:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2020, 13:38

Fabien requested review of this revision.Oct 2 2020, 13:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien added a child revision: D7742: Move Win32 defines to CMakeLists.txt to ensure they are globally defined.Oct 2 2020, 13:40

Harbormaster completed remote builds in B13157: Diff 24206.Oct 2 2020, 13:50

deadalnix accepted this revision.Oct 2 2020, 14:23

This revision is now accepted and ready to land.Oct 2 2020, 14:23

Closed by commit rABCb969a5330c13: windows: Set _WIN32_WINNT to 0x0601 (Windows 7) (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by Fabien). · Explain WhyOct 2 2020, 16:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb969a5330c13: windows: Set _WIN32_WINNT to 0x0601 (Windows 7).

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

4 lines

compat.h

4 lines

init.cpp

17 lines

leveldb/

CMakeLists.txt

1 line

net.cpp

12 lines

netbase.cpp

4 lines

qt/

guiutil.cpp

4 lines

support/

lockedpool.cpp

4 lines

util/

system.cpp

5 lines

Diff 24206

View Options

src/CMakeLists.txt

View Options

src/compat.h

View Options

src/init.cpp

View Options

src/leveldb/CMakeLists.txt

View Options

src/net.cpp

View Options

src/netbase.cpp

View Options

src/qt/guiutil.cpp

View Options

src/support/lockedpool.cpp

View Options

windows: Set _WIN32_WINNT to 0x0601 (Windows 7)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24206

src/CMakeLists.txt

src/compat.h

src/init.cpp

src/leveldb/CMakeLists.txt

src/net.cpp

src/netbase.cpp

src/qt/guiutil.cpp

src/support/lockedpool.cpp

src/util/system.cpp

windows: Set _WIN32_WINNT to 0x0601 (Windows 7)
ClosedPublic
Actions

Revision Contents
Changeset List