Page MenuHomePhabricator

[backport#16578] Do not pass in command line arguments to QApplication
ClosedPublic

Authored by majcosta on Oct 2 2020, 17:32.

Details

Summary

a2714a5c69f0b0506689af04c3e785f71ee0915d Give QApplication dummy arguments (Andrew Chow)

Pull request description:

QApplication takes the command line arguments and parses them itself for some [built in command line arguments](https://doc.qt.io/qt-5/qapplication.html#QApplication) that it has. We don't want any of those built in arguments, so instead give it dummy arguments.

To test, you can use the `-reverse` option. Without this patch, everything will appear right-to-left; things that were on the left side will be on the right and everything is right aligned.

After this patch, `-reverse` will now give a startup error since we do not support this argument.

Backport of Core PR16578

Test Plan
ninja all check check-functional

Check that bitcoin-qt -reverse -regtest gives an error with this patch and reverses the GUI without i.t

Event Timeline

majcosta requested review of this revision.Oct 2 2020, 17:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox requested changes to this revision.Oct 2 2020, 18:20
jasonbcox added a subscriber: jasonbcox.

The summary describes some steps that aren't included in the test plan.

This revision now requires changes to proceed.Oct 2 2020, 18:20
majcosta edited the test plan for this revision. (Show Details)
majcosta removed a reviewer: jasonbcox.

fleshed out test plan

This revision is now accepted and ready to land.Oct 2 2020, 18:53