QA: Avoid re-reading config.ini unnecessarily
ClosedPublic
Actions

Authored by PiRK on Oct 6 2020, 09:21.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCc928ec6217af: QA: Avoid re-reading config.ini unnecessarily

Summary

BitcoinTestFramework.main already loads and stores config.ini on the object itself; just access that instead of re-reading the file to check for features

Backport of Core PR15895

Test Plan

ninja && ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 6 2020, 09:21

Owners added a reviewer: Restricted Owners Package.Oct 6 2020, 09:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 6 2020, 09:21

PiRK requested review of this revision.Oct 6 2020, 09:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13202: Diff 24291.Oct 6 2020, 09:30

deadalnix accepted this revision.Oct 6 2020, 13:01

This revision is now accepted and ready to land.Oct 6 2020, 13:01

Closed by commit rABCc928ec6217af: QA: Avoid re-reading config.ini unnecessarily (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by PiRK). · Explain WhyOct 6 2020, 13:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc928ec6217af: QA: Avoid re-reading config.ini unnecessarily.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_framework.py

15 lines

Diff 24296

View Options

test/functional/test_framework/test_framework.py

QA: Avoid re-reading config.ini unnecessarilyClosedPublicActions