[test] combine_logs: append node stderr and stdout if it exists
AbandonedPublic
Actions

Authored by PiRK on Oct 6 2020, 12:55.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

The first pull request seems less useful, but backporting it makes the second one easier to backport.
Backport of Core PR14683 and PR15841

Test Plan

Intentionaly cause a test to fail, then view the logs with:

./test/functional/combine_logs.py -c './build/test/tmp/test_runner_₿₵_🏃_20201006_144233/feature_block_189'

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr15841

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13205
Build 26456: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang · build-clang-tidy · build-diff
Build 26455: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 6 2020, 12:55

Owners added a reviewer: Restricted Owners Package.Oct 6 2020, 12:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 6 2020, 12:55

PiRK requested review of this revision.Oct 6 2020, 12:55

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Unless 15841 fixes a problem introduced by 14683, there are no reason for these two to be merged together.

This revision now requires changes to proceed.Oct 6 2020, 12:59

Harbormaster completed remote builds in B13205: Diff 24294.Oct 6 2020, 13:02

Change split into two diffs: D7795 and D7796

Revision Contents
Changeset List

Path

Size

test/

functional/

combine_logs.py

152 lines

test_framework/

test_framework.py

3 lines

Diff 24294

View Options

test/functional/combine_logs.py