Page MenuHomePhabricator
Differential D7807

wallet: always do avoid partial spends if fees are within a specified range
ClosedPublic
Actions

Authored by deadalnix on Oct 7 2020, 19:16.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC81fe776b2303: wallet: always do avoid partial spends if fees are within a specified range
Summary
  • wallet: try -avoidpartialspends mode and use its result if fees are below threshold

The threshold is defined by a new max avoid partial spends fee flag, which defaults to 0 (i.e. if fees are unchanged, use the grouped option).

  • test: test the implicit avoid partial spends functionality

Co-authored-by: Fabian Jahr <fjahr@protonmail.com>

This is a backport of Core PR14582

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 7 2020, 19:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2020, 19:16
deadalnix requested review of this revision.Oct 7 2020, 19:16
teamcity edited the summary of this revision. (Show Details)Oct 7 2020, 19:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13248: Diff 24358.Oct 7 2020, 19:43
majcosta requested changes to this revision.Oct 7 2020, 19:59
majcosta added a subscriber: majcosta.
majcosta added inline comments.
test/functional/wallet_groups.py
21 ↗(On Diff #24358)

this is unrelated to the PR unless you want to squash PR18345 into it

This revision now requires changes to proceed.Oct 7 2020, 19:59
deadalnix updated this revision to Diff 24370.Oct 8 2020, 00:08

Fix test

majcosta accepted this revision.Oct 8 2020, 00:13
This revision is now accepted and ready to land.Oct 8 2020, 00:13
Harbormaster completed remote builds in B13255: Diff 24370.Oct 8 2020, 00:20
Closed by commit rABC81fe776b2303: wallet: always do avoid partial spends if fees are within a specified range (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by deadalnix). · Explain WhyOct 8 2020, 12:07
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC81fe776b2303: wallet: always do avoid partial spends if fees are within a specified range.

Revision Contents
Changeset List

PathSize
src/
8 lines
wallet/
7 lines
22 lines
89 lines
test/
functional/
51 lines

Diff 24384

View Options

src/dummywallet.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_groups.py

Loading...