Fix typos in libsecp256k1
ClosedPublic
Actions

Authored by deadalnix on Dec 10 2017, 22:53.

Details

Reviewers

schancel
MattBitprim
Mengerian

Group Reviewers

Restricted Project

Commits

rSTAGING8ccf30e58b6c: Fix typos in libsecp256k1
rABC8ccf30e58b6c: Fix typos in libsecp256k1

Summary

Backport of PR#440 by practicalswift

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secptypo

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1309
Build 1309: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 10 2017, 22:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2017, 22:53

Harbormaster completed remote builds in B1309: Diff 2028.Dec 10 2017, 22:53

Mengerian requested changes to this revision.Dec 11 2017, 00:26

Mengerian added a subscriber: Mengerian.

Mengerian added inline comments.

src/secp256k1/sage/group_prover.sage
20	execured -> executed

This revision now requires changes to proceed.Dec 11 2017, 00:26

Fix the typo without introducing a new one.

Harbormaster completed remote builds in B1328: Diff 2051.Dec 11 2017, 19:38

schancel accepted this revision.Dec 12 2017, 02:26

schancel added inline comments.

src/secp256k1/src/asm/field_10x26_arm.s
26 ↗	(On Diff #2051)	Is this a comment?

deadalnix added inline comments.Dec 12 2017, 03:20

src/secp256k1/src/asm/field_10x26_arm.s
26 ↗	(On Diff #2051)	Yes

Mengerian accepted this revision.Dec 12 2017, 03:29

This revision is now accepted and ready to land.Dec 12 2017, 03:29

Closed by commit rABC8ccf30e58b6c: Fix typos in libsecp256k1 (authored by deadalnix). · Explain WhyDec 12 2017, 12:58

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

sage/

group_prover.sage

2 lines

src/

asm/

field_10x26_arm.s

2 lines

Diff 2028

View Options

src/secp256k1/sage/group_prover.sage