Differential D7816

[CMAKE] Drop native build dependency on Openssl
ClosedPublic
Actions

Authored by Fabien on Oct 8 2020, 06:30.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC6e5b0f906047: [CMAKE] Drop native build dependency on Openssl

Summary

By disabling BIP70 and the secp256k1 Openssl tests for the native build,
the dependency is gone.

Test Plan

cmake -GNinja ..
ninja

Check in the cmake run for the native build that openssl is no longer
searched.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_native_no_openssl

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13259
Build 26559: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang
Build 26558: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 8 2020, 06:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2020, 06:30

Fabien requested review of this revision.Oct 8 2020, 06:30

Harbormaster completed remote builds in B13259: Diff 24379.Oct 8 2020, 07:04

Fabien added a child revision: D7720: [CMAKE] Drop dependency search for the native builds.Oct 8 2020, 07:29

deadalnix accepted this revision.Oct 8 2020, 12:00

This revision is now accepted and ready to land.Oct 8 2020, 12:00

Closed by commit rABC6e5b0f906047: [CMAKE] Drop native build dependency on Openssl (authored by Fabien). · Explain WhyOct 8 2020, 12:23

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6e5b0f906047: [CMAKE] Drop native build dependency on Openssl.

Fabien removed a child revision: D7720: [CMAKE] Drop dependency search for the native builds.Oct 8 2020, 12:25

Fabien added a child revision: D7720: [CMAKE] Drop dependency search for the native builds.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

1 line

secp256k1/

CMakeLists.txt

1 line

Diff 24379

View Options

src/CMakeLists.txt