Page MenuHomePhabricator

Add test for GCC bug 90348
ClosedPublic

Authored by PiRK on Oct 8 2020, 09:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC632478aea336: Add test for GCC bug 90348
Summary

Add a unit test for compiler bug fixed in D5040

This is a backport of Core PR15985

Test Plan
cmake .. -GNinja
ninja && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 8 2020, 09:06
PiRK requested review of this revision.Oct 8 2020, 09:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Snippet of first build failure:

[135/405] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[136/405] Linking CXX executable src/avalanche/test/test-avalanche
[137/405] pow: testing eda_tests
[138/405] Linking CXX executable src/seeder/test/test-seeder
[139/405] pow: testing daa_tests
[140/405] seeder: testing parse_name_tests
[141/405] seeder: testing p2p_messaging_tests
[142/405] avalanche: testing proof_tests
[143/405] Running utility command for check-avalanche-proof_tests
[144/405] Running utility command for check-pow-eda_tests
[145/405] Running utility command for check-pow-daa_tests
[146/405] avalanche: testing peermanager_tests
[147/405] Running utility command for check-avalanche-peermanager_tests
[148/405] seeder: testing write_name_tests
[149/405] Running utility command for check-seeder-parse_name_tests
[150/405] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/init_tests.cpp.o
[151/405] Running utility command for check-seeder-p2p_messaging_tests
[152/405] Running utility command for check-seeder-write_name_tests
[153/405] Running seeder test suite
PASSED: seeder test suite
[154/405] avalanche: testing processor_tests
[155/405] Automatic MOC for target test_bitcoin-qt
[156/405] Running utility command for check-avalanche-processor_tests
[157/405] Running avalanche test suite
PASSED: avalanche test suite
[158/405] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_crypto_tests.cpp.o
[159/405] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/ismine_tests.cpp.o
[160/405] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/psbt_wallet_tests.cpp.o
[161/405] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o
[162/405] Test Bitcoin utilities...
[163/405] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletdb_tests.cpp.o
[164/405] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[165/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[166/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[167/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[168/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[169/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[170/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[171/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[172/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[173/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[174/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[175/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[176/405] pow: testing aserti32d_tests
[177/405] Running utility command for check-pow-aserti32d_tests
[178/405] Running pow test suite
PASSED: pow test suite
[179/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[180/405] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[181/405] Linking CXX executable src/qt/test/test_bitcoin-qt
[182/405] bitcoin-qt: testing test_bitcoin-qt
[183/405] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

fix clang-tidy build failure: add braces to an if clause

deadalnix requested changes to this revision.Oct 8 2020, 12:01
deadalnix added a subscriber: deadalnix.

The test plan doesn't work.

This revision now requires changes to proceed.Oct 8 2020, 12:01

sorry about that. make -> ninja

PiRK requested review of this revision.Oct 9 2020, 06:43
This revision is now accepted and ready to land.Oct 9 2020, 12:00
This revision was automatically updated to reflect the committed changes.