Paths

Table of Contentst

Remove redundant stopThread() signal
ClosedPublic
Actions

Authored by PiRK on Oct 9 2020, 09:33.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC209532350a07: Remove redundant stopThread() signal

Summary

PR description:

The QThread::finished signal do this work.

Backport of Core PR14250, part 1 of 2
Commit 1c0e0a5

Test Plan

ninja && ninja check

Then run src/qt/bitcoin-qt and make sure there are no errors on shutdown.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 9 2020, 09:33

Owners added a reviewer: Restricted Owners Package.Oct 9 2020, 09:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2020, 09:33

PiRK requested review of this revision.Oct 9 2020, 09:33

teamcity edited the summary of this revision. (Show Details)Oct 9 2020, 09:33

Harbormaster completed remote builds in B13294: Diff 24440.Oct 9 2020, 09:42

PiRK added a child revision: D7845: Remove redundant stopExecutor() signal.Oct 9 2020, 09:51

Fabien accepted this revision.Oct 9 2020, 10:07

This revision is now accepted and ready to land.Oct 9 2020, 10:07

Closed by commit rABC209532350a07: Remove redundant stopThread() signal (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyOct 9 2020, 11:29

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC209532350a07: Remove redundant stopThread() signal.

Revision Contents
Changeset List

Path

Size

src/

qt/

1 line

6 lines

1 line

5 lines

Diff 24446

View Options

src/qt/bitcoin.h

View Options

src/qt/bitcoin.cpp

View Options

src/qt/intro.h

View Options

Remove redundant stopThread() signalClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24446

src/qt/bitcoin.h

src/qt/bitcoin.cpp

src/qt/intro.h

src/qt/intro.cpp

Remove redundant stopThread() signal
ClosedPublic
Actions

Revision Contents
Changeset List