Paths

Table of Contentst

Remove redundant stopExecutor() signal
ClosedPublic
Actions

Authored by PiRK on Oct 9 2020, 09:51.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCb8a022d6d69d: Remove redundant stopExecutor() signal

Summary

PR description:

The QThread::finished signal do this work.

This concludes backport of Core PR14250

Commit 24313fb

Depends on D7844

Test Plan

ninja && ninja check

Run src/qt/bitcoin-qt -regtest, open the console and run some RPC commands,
make sure the shutdown works without issues.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 9 2020, 09:51

Owners added a reviewer: Restricted Owners Package.Oct 9 2020, 09:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2020, 09:51

PiRK requested review of this revision.Oct 9 2020, 09:51

teamcity edited the summary of this revision. (Show Details)Oct 9 2020, 09:51

Harbormaster completed remote builds in B13295: Diff 24441.Oct 9 2020, 10:03

Fabien accepted this revision.Oct 9 2020, 10:08

This revision is now accepted and ready to land.Oct 9 2020, 10:08

Closed by commit rABCb8a022d6d69d: Remove redundant stopExecutor() signal (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyOct 9 2020, 11:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb8a022d6d69d: Remove redundant stopExecutor() signal.

Revision Contents
Changeset List

Path

Size

src/

qt/

rpcconsole.h

1 line

rpcconsole.cpp

12 lines

Diff 24448

View Options

src/qt/rpcconsole.h