Page MenuHomePhabricator

qt: Add Window menu
ClosedPublic

Authored by PiRK on Mon, Oct 12, 15:46.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC066a318ae688: qt: Add Window menu
Summary

Overall this PR does the following:

  • add top level menu Window
  • add Minimize and Zoom actions to Window menu
  • move Sending/Receiving address to Window
  • remove Help->Debug menu and add one menu entry for each debug window tab in the Window menu

The ellipsis in the name of Sending/Receiving addresses actions are be removed, according to common practices (https://stackoverflow.com/a/637708).
Ellipsis at the end of the name of menu actions suggest that user input is expected.

Backport of Core PR14573 and PR16514

PR16514 removes the RPCConsole::tabFocus method introduced in the first PR, but never used.

Test Plan

ninja && ninja check

Run src/qt/bitcoin-qt and check that all menu actions work.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mon, Oct 12, 15:46
PiRK requested review of this revision.Mon, Oct 12, 15:46
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/bitcoingui.cpp
555 ↗(On Diff #24567)

This will break compatibility with Qt < 5.6. Make sure to backport PR14979 soon, and eventually D7893 will also prevent introducing a bug.

This revision is now accepted and ready to land.Mon, Oct 12, 18:16
This revision was automatically updated to reflect the committed changes.