Page MenuHomePhabricator

[Qt] Restore < Qt5.6 compatibility for addAction
ClosedPublic

Authored by PiRK on Mon, Oct 12, 19:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCb01ba2ed250c: [Qt] Restore < Qt5.6 compatibility for addAction
Summary

PR14573 / D7892 broke Qt5.6 compatibility due to calling the lambda version of addAction that was added in Qt5.6.

Backport of Core PR14979

Test Plan

ninja && ninja check
Run src/qt/bitcoin-qt and test all menu actions

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mon, Oct 12, 19:10
PiRK requested review of this revision.Mon, Oct 12, 19:10
Fabien added a subscriber: Fabien.

@jasonbcox It is not needed anymore but it doesn't hurt either, so better have less merge conflicts for future backports

This revision is now accepted and ready to land.Tue, Oct 13, 06:10