Page MenuHomePhabricator
Differential D7894

[Qt] Restore < Qt5.6 compatibility for addAction
ClosedPublic
Actions

Authored by PiRK on Oct 12 2020, 19:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCb01ba2ed250c: [Qt] Restore < Qt5.6 compatibility for addAction
Summary

PR14573 / D7892 broke Qt5.6 compatibility due to calling the lambda version of addAction that was added in Qt5.6.

Backport of Core PR14979

Test Plan

ninja && ninja check
Run src/qt/bitcoin-qt and test all menu actions

Diff Detail

Event Timeline

PiRK created this revision.Oct 12 2020, 19:10
Owners added a reviewer: Restricted Owners Package.Oct 12 2020, 19:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2020, 19:10
PiRK requested review of this revision.Oct 12 2020, 19:10
teamcity edited the summary of this revision. (Show Details)Oct 12 2020, 19:10
PiRK added a child revision: D7895: qt: Fix Window -> Minimize menu item on linux.Oct 12 2020, 19:21
Harbormaster completed remote builds in B13367: Diff 24573.Oct 12 2020, 20:23
jasonbcox added a subscriber: jasonbcox.Oct 12 2020, 22:15

Is this change necessary given D7893 ?

Fabien accepted this revision.Oct 13 2020, 06:10
Fabien added a subscriber: Fabien.

@jasonbcox It is not needed anymore but it doesn't hurt either, so better have less merge conflicts for future backports

This revision is now accepted and ready to land.Oct 13 2020, 06:10
Closed by commit rABCb01ba2ed250c: [Qt] Restore < Qt5.6 compatibility for addAction (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by PiRK). · Explain WhyOct 13 2020, 08:20
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCb01ba2ed250c: [Qt] Restore < Qt5.6 compatibility for addAction.

Revision Contents
Changeset List

PathSize
src/
qt/
32 lines

Diff 24573

View Options

src/qt/bitcoingui.cpp

Loading...