qt: Add Window menu
ClosedPublic
Actions

Authored by PiRK on Oct 12 2020, 15:46.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC066a318ae688: qt: Add Window menu

Summary

Overall this PR does the following:

add top level menu Window
add Minimize and Zoom actions to Window menu
move Sending/Receiving address to Window
remove Help->Debug menu and add one menu entry for each debug window tab in the Window menu

The ellipsis in the name of Sending/Receiving addresses actions are be removed, according to common practices (https://stackoverflow.com/a/637708).
Ellipsis at the end of the name of menu actions suggest that user input is expected.

Backport of Core PR14573 and PR16514

PR16514 removes the RPCConsole::tabFocus method introduced in the first PR, but never used.

Test Plan

ninja && ninja check

Run src/qt/bitcoin-qt and check that all menu actions work.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 12 2020, 15:46

Owners added a reviewer: Restricted Owners Package.Oct 12 2020, 15:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2020, 15:46

PiRK requested review of this revision.Oct 12 2020, 15:46

teamcity edited the summary of this revision. (Show Details)Oct 12 2020, 15:47

Harbormaster completed remote builds in B13365: Diff 24567.Oct 12 2020, 15:54

Fabien mentioned this in D7893: Bump our minimal Qt version to 5.9.5.Oct 12 2020, 17:22

Fabien accepted this revision.Oct 12 2020, 18:16

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/qt/bitcoingui.cpp
555 ↗	(On Diff #24567)	This will break compatibility with Qt < 5.6. Make sure to backport PR14979 soon, and eventually D7893 will also prevent introducing a bug.