Page MenuHomePhabricator
Differential D7896

[backport#15163] Correct units for "-dbcache" and "-prune"
ClosedPublic
Actions

Authored by majcosta on Oct 12 2020, 19:49.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCb94d4864933e: [backport#15163] Correct units for "-dbcache" and "-prune"
Summary

6f6514a08090b37b5e8c086015ee4881813ef867 Correct units for "-dbcache" and "-prune" (Hennadii Stepanov)

Pull request description:

Actually, all `dbcache`-related values in the code are measured in MiB (not in megabytes, MB) or in bytes (e.g., `nTotalCache`).

See: https://github.com/bitcoin/bitcoin/blob/master/src/txdb.h

https://github.com/bitcoin/bitcoin/blob/ba8c8b22272ad40fe2de465d7e745532bab48d3b/src/init.cpp#L1405-L1424

Also, "-prune" is fixed:
1. The GUI values in GB are translated to the node values in MiB correctly.
2. The maximum of the "prune" `QSpinBox` is not limited by default value of 99 (GB).

Fix: #15106

Backport of Core PR15163

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
17 lines
qt/
forms/
2 lines
3 lines
2 lines
17 lines
8 lines
9 lines
test/
functional/
2 lines

Diff 24578

View Options

src/init.cpp

Loading...
View Options

src/qt/forms/optionsdialog.ui

Loading...
View Options

src/qt/guiconstants.h

Loading...
View Options

src/qt/intro.cpp

Loading...
View Options

src/qt/optionsdialog.cpp

Loading...
View Options

src/qt/optionsmodel.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

test/functional/feature_pruning.py

Loading...