Paths

Table of Contentst

Differential D789

Prepare remainder of qt package for explicit Amount construction
ClosedPublic
Actions

Authored by schancel on Dec 11 2017, 19:09.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGd3305e617c3a: Prepare remainder of qt package for explicit Amount construction
rABCd3305e617c3a: Prepare remainder of qt package for explicit Amount construction

Summary

Depends on D788

Test Plan

make check
Run QT GUI

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1324
Build 1324: arc lint + arc unit

Event Timeline

schancel created this revision.Dec 11 2017, 19:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 11 2017, 19:09

schancel added a child revision: D790: Complete explicit Amount construction in Qt code.Dec 11 2017, 19:10

deadalnix accepted this revision.Dec 11 2017, 20:47

deadalnix added inline comments.

src/qt/paymentserver.cpp
566	This comment is wrong now.

This revision is now accepted and ready to land.Dec 11 2017, 20:47

Closed by commit rABCd3305e617c3a: Prepare remainder of qt package for explicit Amount construction (authored by schancel). · Explain WhyDec 12 2017, 14:33

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoin.cpp

4 lines

bitcoinamountfield.cpp

4 lines

bitcoingui.h

6 lines

bitcoingui.cpp

2 lines

coincontroldialog.h

2 lines

coincontroldialog.cpp

35 lines

guiutil.cpp

5 lines

paymentrequestplus.h

2 lines

paymentrequestplus.cpp

4 lines

paymentserver.h

2 lines

paymentserver.cpp

10 lines

receivecoinsdialog.cpp

3 lines

sendcoinsdialog.cpp

16 lines

sendcoinsentry.cpp

2 lines

test/

paymentservertests.cpp

4 lines

transactiondesc.cpp

59 lines

transactionfilterproxy.h

4 lines

transactionfilterproxy.cpp

2 lines

transactionrecord.h

8 lines

transactionrecord.cpp

13 lines

transactiontablemodel.cpp

4 lines

transactionview.cpp

2 lines

walletview.h

6 lines

walletview.cpp

4 lines

Diff 2043

View Options

src/qt/bitcoin.cpp

View Options

src/qt/bitcoinamountfield.cpp

View Options

src/qt/bitcoingui.h

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/coincontroldialog.h

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/guiutil.cpp

View Options

src/qt/paymentrequestplus.h

View Options

src/qt/paymentrequestplus.cpp

View Options

src/qt/paymentserver.h

View Options

src/qt/paymentserver.cpp

View Options

src/qt/receivecoinsdialog.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/sendcoinsentry.cpp

View Options

src/qt/test/paymentservertests.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionfilterproxy.h

View Options

src/qt/transactionfilterproxy.cpp

View Options

src/qt/transactionrecord.h

View Options

src/qt/transactionrecord.cpp

View Options

src/qt/transactiontablemodel.cpp

View Options

src/qt/transactionview.cpp

View Options

src/qt/walletview.h

View Options

Prepare remainder of qt package for explicit Amount constructionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2043

src/qt/bitcoin.cpp

src/qt/bitcoinamountfield.cpp

src/qt/bitcoingui.h

src/qt/bitcoingui.cpp

src/qt/coincontroldialog.h

src/qt/coincontroldialog.cpp

src/qt/guiutil.cpp

src/qt/paymentrequestplus.h

src/qt/paymentrequestplus.cpp

src/qt/paymentserver.h

src/qt/paymentserver.cpp

src/qt/receivecoinsdialog.cpp

src/qt/sendcoinsdialog.cpp

src/qt/sendcoinsentry.cpp

src/qt/test/paymentservertests.cpp

src/qt/transactiondesc.cpp

src/qt/transactionfilterproxy.h

src/qt/transactionfilterproxy.cpp

src/qt/transactionrecord.h

src/qt/transactionrecord.cpp

src/qt/transactiontablemodel.cpp

src/qt/transactionview.cpp

src/qt/walletview.h

src/qt/walletview.cpp

Prepare remainder of qt package for explicit Amount construction
ClosedPublic
Actions

Revision Contents
Changeset List