Explicitly construct Amount types.
Depends on D789.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING4ffc5b345907: Complete explicit Amount construction in Qt code
rABC4ffc5b345907: Complete explicit Amount construction in Qt code
make check
Run QT GUI
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1329 Build 1329: arc lint + arc unit
Event Timeline
| src/qt/bitcoinamountfield.cpp | ||
|---|---|---|
| 138 ↗ | (On Diff #2044) | Amount val(0); |
| src/qt/paymentrequestplus.cpp | ||
| 229 ↗ | (On Diff #2044) | Make that thing return an amount. |
| src/qt/walletmodel.cpp | ||
| 179 ↗ | (On Diff #2044) | Amount total(0); |
| 198 ↗ | (On Diff #2044) | dito |
| 204 ↗ | (On Diff #2044) | Make this amount function return an amount. |
| src/qt/walletview.cpp | ||
| 195 ↗ | (On Diff #2044) | One would expect amount to be an amount. |
| src/qt/paymentrequestplus.cpp | ||
|---|---|---|
| 229 ↗ | (On Diff #2044) | It looks like it's protobufs stuff. I looked into it. |
Comment Actions
payments:: stuff is coming from protobufs definitions.`. I'm not sure about adding Amount class to that.
// Generalized form of "send payment to this/these bitcoin cash addresses"
message Output {
optional uint64 amount = 1 [default = 0]; // amount is integer-number-of-satoshis
required bytes script = 2; // usually one of the standard Script forms
}| src/qt/paymentrequestplus.cpp | ||
|---|---|---|
| 229 ↗ | (On Diff #2044) | ok |