Paths

Table of Contentst

log: harmonize bitcoind server logging
ClosedPublic
Actions

Authored by PiRK on Oct 15 2020, 14:26.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC3d50b09d9012: log: harmonize bitcoind server logging

Summary

PR description:

Harmonize the user-facing output of the bitcoind -daemon, bitcoin-cli help stop, bitcoin-cli stop, and bitcoind -version commands to be consistent with each other.

Backport of PR16489

Test Plan

ninja && ninja check

Check consistency in the output of following commands!

src/bitcoind -version
src/bitcoind -daemon
src/bitcoin-cli help stop
src/bitcoin-cli stop

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 15 2020, 14:26

Owners added a reviewer: Restricted Owners Package.Oct 15 2020, 14:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2020, 14:26

PiRK requested review of this revision.Oct 15 2020, 14:26

PiRK edited the summary of this revision. (Show Details)Oct 15 2020, 14:35

Harbormaster completed remote builds in B13416: Diff 24658.Oct 15 2020, 14:39

deadalnix requested changes to this revision.Oct 15 2020, 14:55

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/rpc/server.cpp
211 ↗	(On Diff #24658)	Revert

This revision now requires changes to proceed.Oct 15 2020, 14:55

add blank line accidentaly deleted

Harbormaster completed remote builds in B13429: Diff 24674.Oct 15 2020, 18:57

deadalnix accepted this revision.Oct 15 2020, 21:53

This revision is now accepted and ready to land.Oct 15 2020, 21:53

PiRK added a child revision: D7946: fix gen-manpages.sh to take into account shorter `bitcoind --version` line.Oct 16 2020, 07:36

Closed by commit rABC3d50b09d9012: log: harmonize bitcoind server logging (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyOct 16 2020, 07:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC3d50b09d9012: log: harmonize bitcoind server logging.

Revision Contents
Changeset List

Path

Size

src/

bitcoind.cpp

9 lines

rpc/

server.cpp

4 lines

Diff 24707

View Options

src/bitcoind.cpp